Optimize the rendering logic for the Collapse and Tabs child components(#101)

This commit is contained in:
liao文禧 2024-05-13 11:14:51 +08:00
parent 0d39919889
commit 2695e5b8a2
8 changed files with 27 additions and 21 deletions

View File

@ -27,7 +27,7 @@ export default function Issues() {
}, [tables, relationships, issues, types]); }, [tables, relationships, issues, types]);
return ( return (
<Collapse style={{ width: "100%" }}> <Collapse keepDOM lazyRender style={{ width: "100%" }}>
<Collapse.Panel <Collapse.Panel
header={ header={
<Badge <Badge

View File

@ -33,6 +33,8 @@ export default function NotesTab() {
) : ( ) : (
<Collapse <Collapse
activeKey={selectedElement.open ? `${selectedElement.id}` : ""} activeKey={selectedElement.open ? `${selectedElement.id}` : ""}
keepDOM
lazyRender
onChange={(activeKey) => { onChange={(activeKey) => {
setSelectedElement((prev) => ({ setSelectedElement((prev) => ({
...prev, ...prev,

View File

@ -19,6 +19,8 @@ export default function RelationshipsTab() {
? `${selectedElement.id}` ? `${selectedElement.id}`
: "" : ""
} }
keepDOM
lazyRender
onChange={(k) => onChange={(k) =>
setSelectedElement((prev) => ({ setSelectedElement((prev) => ({
...prev, ...prev,

View File

@ -1,4 +1,4 @@
import { Tabs } from "@douyinfe/semi-ui"; import { Tabs, TabPane } from "@douyinfe/semi-ui";
import { Tab } from "../../data/constants"; import { Tab } from "../../data/constants";
import { useLayout, useSelect } from "../../hooks"; import { useLayout, useSelect } from "../../hooks";
import RelationshipsTab from "./RelationshipsTab/RelationshipsTab"; import RelationshipsTab from "./RelationshipsTab/RelationshipsTab";
@ -13,19 +13,11 @@ export default function SidePanel({ width, resize, setResize }) {
const { selectedElement, setSelectedElement } = useSelect(); const { selectedElement, setSelectedElement } = useSelect();
const tabList = [ const tabList = [
{ tab: "Tables", itemKey: Tab.TABLES }, { tab: "Tables", itemKey: Tab.TABLES, component: <TablesTab /> },
{ tab: "Relationships", itemKey: Tab.RELATIONSHIPS }, { tab: "Relationships", itemKey: Tab.RELATIONSHIPS, component: <RelationshipsTab /> },
{ tab: "Subject Areas", itemKey: Tab.AREAS }, { tab: "Subject Areas", itemKey: Tab.AREAS, component: <AreasTab /> },
{ tab: "Notes", itemKey: Tab.NOTES }, { tab: "Notes", itemKey: Tab.NOTES, component: <NotesTab /> },
{ tab: "Types", itemKey: Tab.TYPES }, { tab: "Types", itemKey: Tab.TYPES, component: <TypesTab /> },
];
const contentList = [
<TablesTab key="tables" />,
<RelationshipsTab key="relationships" />,
<AreasTab key="areas" />,
<NotesTab key="notes" />,
<TypesTab key="types" />,
]; ];
return ( return (
@ -38,15 +30,19 @@ export default function SidePanel({ width, resize, setResize }) {
<Tabs <Tabs
type="card" type="card"
activeKey={selectedElement.currentTab} activeKey={selectedElement.currentTab}
tabList={tabList} lazyRender
onChange={(key) => onChange={(key) =>
setSelectedElement((prev) => ({ ...prev, currentTab: key })) setSelectedElement((prev) => ({ ...prev, currentTab: key }))
} }
collapsible collapsible
> >
{tabList.length && tabList.map(tab =>
<TabPane tab={tab.tab} itemKey={tab.itemKey} key={tab.itemKey}>
<div className="p-2"> <div className="p-2">
{contentList[parseInt(selectedElement.currentTab) - 1]} {tab.component}
</div> </div>
</TabPane>
)}
</Tabs> </Tabs>
</div> </div>
{layout.issues && ( {layout.issues && (

View File

@ -144,6 +144,8 @@ export default function TableInfo({ data }) {
> >
<Collapse <Collapse
activeKey={indexActiveKey} activeKey={indexActiveKey}
keepDOM
lazyRender
onChange={(itemKey) => setIndexActiveKey(itemKey)} onChange={(itemKey) => setIndexActiveKey(itemKey)}
accordion accordion
> >
@ -169,7 +171,7 @@ export default function TableInfo({ data }) {
style={{ marginTop: "12px", marginBottom: "12px" }} style={{ marginTop: "12px", marginBottom: "12px" }}
headerLine={false} headerLine={false}
> >
<Collapse> <Collapse keepDOM lazyRender>
<Collapse.Panel header="Comment" itemKey="1"> <Collapse.Panel header="Comment" itemKey="1">
<TextArea <TextArea
field="comment" field="comment"

View File

@ -31,6 +31,8 @@ export default function TablesTab() {
? `${selectedElement.id}` ? `${selectedElement.id}`
: "" : ""
} }
keepDOM
lazyRender
onChange={(k) => onChange={(k) =>
setSelectedElement((prev) => ({ setSelectedElement((prev) => ({
...prev, ...prev,

View File

@ -64,7 +64,7 @@ export default function TypeInfo({ index, data }) {
style={{ marginTop: "12px", marginBottom: "12px" }} style={{ marginTop: "12px", marginBottom: "12px" }}
headerLine={false} headerLine={false}
> >
<Collapse> <Collapse keepDOM lazyRender>
<Collapse.Panel header="Comment" itemKey="1"> <Collapse.Panel header="Comment" itemKey="1">
<TextArea <TextArea
field="comment" field="comment"

View File

@ -60,6 +60,8 @@ export default function TypesTab() {
? `${selectedElement.id}` ? `${selectedElement.id}`
: "" : ""
} }
keepDOM
lazyRender
onChange={(id) => onChange={(id) =>
setSelectedElement((prev) => ({ setSelectedElement((prev) => ({
...prev, ...prev,